refactor(pathfinder): unify header search architecture with library loading pattern#1738
Merged
cpcloud merged 1 commit intoNVIDIA:mainfrom Mar 11, 2026
Merged
Conversation
Contributor
cpcloud
force-pushed
the
header-finding-refactor
branch
from
a65ef88 to
3c96fcc
Compare
Contributor
|
Auto-sync is disabled for ready for review pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
Contributor
Author
|
/ok to test |
cpcloud
force-pushed
the
header-finding-refactor
branch
from
3c96fcc to
550bd47
Compare
Contributor
Author
|
/ok to test |
cpcloud
force-pushed
the
header-finding-refactor
branch
from
550bd47 to
643fec9
Compare
This comment has been minimized.
This comment has been minimized.
cpcloud
force-pushed
the
header-finding-refactor
branch
from
643fec9 to
b26cf85
Compare
Contributor
Author
|
/ok to test |
leofang
reviewed
Mar 7, 2026
Mirror the dynamic-library descriptor-catalog pattern for headers. All per-header metadata (basename, site-packages dirs, anchor layout, platform availability, system install dirs) is now authored once in HeaderDescriptorSpec entries in header_descriptor_catalog.py. - header_descriptor_catalog.py: authored catalog with HeaderDescriptorSpec; each entry declares its own search capabilities via fields like use_ctk_root_canary, conda_targets_layout, and system_install_dirs - header_descriptor.py: name-keyed HEADER_DESCRIPTORS registry and platform-dispatch helpers (platform_include_subdirs, resolve_conda_anchor) - supported_nvidia_headers.py: derives legacy tables from the catalog - find_nvidia_headers.py: composable HeaderFindStep functions with a single unified FIND_STEPS sequence and run_find_steps cascade runner; each step self-gates based on descriptor fields; search code is platform-agnostic Public API (LocatedHeaderDir, find_nvidia_header_directory, locate_nvidia_header_directory, SUPPORTED_HEADERS_CTK) is unchanged. Made-with: Cursor
cpcloud
force-pushed
the
header-finding-refactor
branch
from
b26cf85 to
9ff02da
Compare
Contributor
Author
|
/ok to test |
Andy-Jost
reviewed
Mar 11, 2026
Andy-Jost
approved these changes
Mar 11, 2026
Contributor
Andy-Jost
left a comment
Andy-Jost
left a comment
There was a problem hiding this comment.
I don't see any issues.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
HeaderDescriptorSpecdescriptor catalog for headers, mirroring theDescriptorSpeccatalog pattern already used for dynamic library loading. All per-header metadata (basename, site-packages dirs, anchor layout, platform availability, system install dirs) is now authored once in a single catalog tuple, rather than spread across several manually maintained dicts.supported_nvidia_headers.pynow derives its legacy table exports from the catalog (same approach assupported_nvidia_libs.py), andfind_nvidia_headers.pyoperates on descriptors directly — eliminating the name-basedif libname == "nvvm"/if libname == "cccl"branching in favor of descriptor fields (anchor_include_rel_dirs,include_subdirs,include_subdirs_windows).LocatedHeaderDir,find_nvidia_header_directory,locate_nvidia_header_directory,SUPPORTED_HEADERS_CTK) is unchanged.Intentional behavioral note: The old code raised
RuntimeErrorwhen callinglocate_nvidia_header_directorywith a header name not available on the current platform (e.g.,"cufile"on Windows). The new code returnsNoneinstead, since the descriptor exists but the search simply finds nothing. This is more consistent with how callers handle "not found" and mirrors the library side's distinction between unknown vs. unavailable.Test plan
test_find_nvidia_headers.py)test_descriptor_catalog.py)Made with Cursor